On Fri, 2013-02-15 at 21:50 +0100, Lubos Lunak wrote:
PPS: please do not shoot the messenger...
I'm not shooting the messenger, I'm telling him that the way it is he'll
sooner or later need to go on more errands.
Heh; so "do not merge" is the equivalent of "do not submit" but much
clearer and friendlier, fits inside the text limit.
We need to be -very- polite, respectful and encouraging to those who
have managed not only to build LibreOffice, but setup a gerrit account,
change the code and finally submit it to gerrit. Potentially one
reviewer might transiently not like the approach enough to block it -
that's fine, but IMHO we need to make that message more appropriate -
which AFAICS is now done :-)
Are people really contesting "do not merge" ?
If so, there is an ESC call next week to discuss it of course, and
you're welcome to put your points.
All the best,
Michael.
--
michael.meeks@suse.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.