Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


On Fri, Feb 15, 2013 at 9:55 AM, Michael Meeks <michael.meeks@suse.com> wrote:

On Fri, 2013-02-15 at 16:16 +0100, Eike Rathke wrote:
    + "Do not submit" ->
            "I would prefer this not to be committed in this state."

While the rewording for -1 is fine with me and in general also better
describes why a -1 is given, I'm not satisfied with the "-2 Do not

        I think we changed -2 to "do not merge" instead after some private
discussion with Norbert :-) I think the consensus is that we shouldn't
be using -2 unless there is something drastically wrong.

For the record:

Although -1 'description' has been toned down, it is _still_ the
preferred and recommended way to express that a patch should not be
push as is.

-2 is essentially a veto on the 'idea' of the patch. -1 get reset when
a new version of a patch is uploaded, whereas -2 are 'sticky'.

Norbert

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.