Hi, On Thursday, 2013-02-14 17:08:43 +0000, Michael Meeks wrote:
* UX input (Mirek)
+ 4.0/4.x branding
+ E-mail voting results:
https://docs.google.com/spreadsheet/ccc?key=0AsGS28t6YMF3dHFrTm9hMzZVNk9hNEZMN0NSbV9ZbXc#gid=0
I'd much prefer if we could publish such things at places where no login of whatever kind is needed.
* Gerrit - unpleasant (Michael)
+ "I would prefer that you didn't submit this" ->
"This probably needs some tweaks before it is merged"
+ "Do not submit" ->
"I would prefer this not to be committed in this state."
While the rewording for -1 is fine with me and in general also better describes why a -1 is given, I'm not satisfied with the "-2 Do not submit" case. At least I use -2 only if the code is wrong or would break things or omits important cases, there's no personal preferation involved, the change should simply not be submitted. Maybe "The change can not be committed in this state." instead would do? Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. New GnuPG key 0x65632D3A : 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Old GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
Attachment:
pgpzPB2NDFA9o.pgp
Description: PGP signature