Hi,
On Friday, 2013-02-15 14:30:33 -0600, Norbert Thiebaud wrote:
-2 is effectively a veto because it is a sticky state that
remain even if a new version of the patch is uploaded... so as long as
there is a -2 one cannot Submit the patch, short of hacking gerrit or
pushing the patch directly to master, by-passsing gerrit-review
altogether.
And of course the "clean" solution, a -2 can also be reverted by the
reviewer who issued the -2 if the follow-up patch addresses the
concerns.
Eike
--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
New GnuPG key 0x65632D3A : 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A
Old GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
Attachment:
pgpNsfNxdOQIn.pgp
Description: PGP signature
Context
- Re: [Libreoffice-qa] minutes of ESC call ... (continued)
Re: [Libreoffice-qa] minutes of ESC call ... · Bjoern Michaelsen
Re: [Libreoffice-qa] minutes of ESC call ... · Eike Rathke
Re: minutes of ESC call ... · Bjoern Michaelsen
RHEL-5 baseline, was Re: minutes of ESC call ... · Caolán McNamara
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.