Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


Please disregard my Friday patch for Impress.

Removing the Global High Contrast flag is going to require more work then the simple remove HC 
icons project is going to allow. We hard code too many UI items (text fonts, background color, 
border color, ...) which have to be modified when in HC mode. The correct fix for this would be:

1. Find all colors
2. Sort and standardize use.
3. Fix the Color Editor to include all the codes.
4. Replace all the hard coded entries to take values from the color chart.
5. Ship a HC and Normal color theme
6. Bonus points for getting the above to work with all the system color themes...

I'm going to revert most of the Impress patch and then resubmit with only the Icon related changes.

Joe P.

PS: Removing the global flag did find a few odd cases of where Icon related code was hiding so it 
wasn't a complete loss.

PS: In master, the text labels for the HC colors are missing. I'm going to see if I did that and 
see about getting the labels back in. I may end up asking someone with better GIT skills then me to 
help find the patch and see about getting it fixed. If I can't find it in GIT, I'll check the 3.3 
branch and see if it has the labels and then just copy the code back into master.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.