Re: [Libreoffice] [PATCH] Impress

Hi there,

On Mon, 2010-11-22 at 07:11 -0800, Joseph Powers wrote:
> Please disregard my Friday patch for Impress.

        :-)

> Removing the Global High Contrast flag is going to require more work
> then the simple remove HC icons project is going to allow. We hard
> code too many UI items (text fonts, background color, border
> color, ...) which have to be modified when in HC mode. The correct fix
> for this would be:

        Well; all of these (I hope) are already theme-able, and if not; well
they should be.

> 4. Replace all the hard coded entries to take values from the color chart.

        Right - we currently do this by having lots of accessor methods to get
and set colors; maActiveBorderColor, maActiveColor,
maButtonRolloverTextColor ... [etc. etc.] cf.
vcl/source/app/settings.cxx.

        There are so many there ( 45 or so ), that surely we have -something-
we can use as a color value to render whatever it is ? :-) 

> 5. Ship a HC and Normal color theme

        Clearly we need to set these colors to an HC set when in that mode; but
the data is there already surely ?

> I'm going to revert most of the Impress patch and then resubmit
> with only the Icon related changes.

        I think it makes sense to do the icon stuff first.

> PS: Removing the global flag did find a few odd cases of where Icon
> related code was hiding so it wasn't a complete loss.

        :-)

> PS: In master, the text labels for the HC colors are missing. I'm
> going to see if I did that and see about getting the labels back
> in. I may end up asking someone with better GIT skills then me
> to help find the patch and see about getting it fixed. If I can't
> find it in GIT, I'll check the 3.3 branch and see if it has the
> labels and then just copy the code back into master.

        Makes sense.

        Thanks !

                Michael.

PS. really pleased to see the image size decrease in the new theme from
4.8Mb to 3.3Mb - still lots of low hanging fruit there, with the
duplicate "missing icon" icons, and the res/commandimagelist -> cmd/
rename to save that space ...
-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot