Re: [Libreoffice] [PATCH] Impress

On 22/11/10 15:11, Joseph Powers wrote:
> Please disregard my Friday patch for Impress.
>
> Removing the Global High Contrast flag is going to require more work then the simple remove HC 
> icons project is going to allow. We hard code too many UI items (text fonts, background color, 
> border color, ...) which have to be modified when in HC mode. The correct fix for this would be:
>
> 1. Find all colors
> 2. Sort and standardize use.
> 3. Fix the Color Editor to include all the codes.
> 4. Replace all the hard coded entries to take values from the color chart.
> 5. Ship a HC and Normal color theme
> 6. Bonus points for getting the above to work with all the system color themes...
>
> I'm going to revert most of the Impress patch and then resubmit with only the Icon related 
> changes.
>
> Joe P.
>
> PS: Removing the global flag did find a few odd cases of where Icon related code was hiding so it 
> wasn't a complete loss.
>
> PS: In master, the text labels for the HC colors are missing. I'm going to see if I did that and 
> see about getting the labels back in. I may end up asking someone with better GIT skills then me 
> to help find the patch and see about getting it fixed. If I can't find it in GIT, I'll check the 
> 3.3 branch and see if it has the labels and then just copy the code back into master.
Is this the patch header? With commit number etc?

From e24ca90c227d74300f6b168cbe601404d37ab850 Mon Sep 17 00:00:00 2001
From: Joseph Powers <jpowers27@cox.net>
Date: Fri, 19 Nov 2010 19:17:37 -0800
Subject: [PATCH] Removing GetHighContrast() from Impress


Cheers,
Wol