[Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

Hi,

I have fixed some compilation warnings in binfilter and some unnecessary
comments. Patch is attached for review.

I have two questions:
 - /*N*/ . Should I fix them massively? I have currently left them unchanged
to avoid a big cleanup patch.
 - Unused parameters in some methods are triggering compilation warnings.
Should I fix them by removing the parameter name ?

Regards,
Joachim.

diff --git a/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx 
b/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
index d26ff12..e1d828c 100644
--- a/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
+++ b/binfilter/bf_sc/source/core/tool/sc_chartlis.cxx
@@ -67,8 +67,8 @@ using namespace ::com::sun::star;
 /*N*/ ScChartListener::ScChartListener( const String& rName, ScDocument* pDocP,
 /*N*/          const ScRange& rRange ) :
 /*N*/  StrData( rName ),
-/*N*/  pDoc( pDocP ),
 /*N*/  pUnoData( NULL ),
+/*N*/  pDoc( pDocP ),
 /*N*/  bUsed( FALSE ),
 /*N*/  bDirty( FALSE ),
 /*N*/  bSeriesRangesScheduled( FALSE )
@@ -80,8 +80,8 @@ using namespace ::com::sun::star;
 /*N*/          const ScRangeListRef& rRangeList ) :
 /*N*/  StrData( rName ),
 /*N*/  aRangeListRef( rRangeList ),
-/*N*/  pDoc( pDocP ),
 /*N*/  pUnoData( NULL ),
+/*N*/  pDoc( pDocP ),
 /*N*/  bUsed( FALSE ),
 /*N*/  bDirty( FALSE ),
 /*N*/  bSeriesRangesScheduled( FALSE )
@@ -90,8 +90,9 @@ using namespace ::com::sun::star;
 
 /*N*/ ScChartListener::ScChartListener( const ScChartListener& r ) :
 /*N*/          StrData( r ),
-/*N*/          pDoc( r.pDoc ),
+               SfxListener( r ),
 /*N*/          pUnoData( NULL ),
+/*N*/          pDoc( r.pDoc ),
 /*N*/          bUsed( FALSE ),
 /*N*/          bDirty( r.bDirty ),
 /*N*/          bSeriesRangesScheduled( r.bSeriesRangesScheduled )
@@ -111,14 +112,13 @@ using namespace ::com::sun::star;
 
 /*N*/ DataObject* ScChartListener::Clone() const
 /*N*/ {
-        DBG_BF_ASSERT(0, "STRIP");return NULL; //STRIP001 return new ScChartListener( *this );
+        DBG_BF_ASSERT(0, "STRIP");return NULL;
 /*N*/ }
 
 /*N*/ void ScChartListener::SetUno(
 /*N*/          const uno::Reference< chart::XChartDataChangeEventListener >& rListener,
 /*N*/          const uno::Reference< chart::XChartData >& rSource )
 /*N*/ {
-/*N*/ //       DBG_ASSERT( rListener.is() && rSource.is(), "Nullpointer bei SetUno" );
 /*N*/  delete pUnoData;
 /*N*/  pUnoData = new ScChartUnoData( rListener, rSource );
 /*N*/ }
@@ -236,14 +236,14 @@ using namespace ::com::sun::star;
 
 /*N*/ DataObject*      ScChartListenerCollection::Clone() const
 /*N*/ {
-        DBG_BF_ASSERT(0, "STRIP");return NULL;//STRIP001       return new 
ScChartListenerCollection( *this );
+        DBG_BF_ASSERT(0, "STRIP");return NULL;
 /*N*/ }
 
 
 /*N*/ void ScChartListenerCollection::ChangeListening( const String& rName,
 /*N*/          const ScRangeListRef& rRangeListRef, BOOL bDirty )
 /*N*/ {
-/*?*/  DBG_BF_ASSERT(0, "STRIP"); //STRIP001 ScChartListener aCLSearcher( rName, pDoc, 
rRangeListRef );
+/*?*/  DBG_BF_ASSERT(0, "STRIP");
 /*N*/ }
 
 /*N*/ void ScChartListenerCollection::FreeUnused()
@@ -330,7 +330,7 @@ using namespace ::com::sun::star;
 /*N*/ {
 /*N*/  for ( USHORT nIndex = 0; nIndex < nCount; nIndex++ )
 /*N*/  {
-/*?*/          DBG_BF_ASSERT(0, "STRIP"); //STRIP001 ScChartListener* pCL = (ScChartListener*) 
pItems[ nIndex ];
+/*?*/          DBG_BF_ASSERT(0, "STRIP");
 /*N*/  }
 /*N*/ }
 
@@ -340,7 +340,7 @@ using namespace ::com::sun::star;
 /*N*/  ScRange aRange( 0, 0, nTab, MAXCOL, MAXROW, nTab );
 /*N*/  for ( USHORT nIndex = 0; nIndex < nCount; nIndex++ )
 /*N*/  {
-/*?*/          DBG_BF_ASSERT(0, "STRIP"); //STRIP001 ScChartListener* pCL = (ScChartListener*) 
pItems[ nIndex ];
+/*?*/          DBG_BF_ASSERT(0, "STRIP");
 /*N*/  }
 /*N*/ }