Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

Caolán McNamara <caolanm -AT- redhat.com>
Tue, 23 Nov 2010 20:44:15 +0000

On Tue, 2010-11-23 at 21:05 +0100, Pierre-André Jacquod wrote:

To have a better code, would it not be better to change the prototyping
of the function from foo (int) to foo() ?? Or did I miss a point?


It would be better, *but* often these are virtual methods and have to
retain their signature to remain virtual, not always, but sometimes and
it can be tricky to get right. For the case of the binfilter its just
easier to guarantee lockin the current behaviour.

C.

Context

[Libreoffice] [patch] binfilter: cleanup and compilation warnings removal. · Joachim Trémouroux
- Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal. · Michael Meeks
  - Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal. · Norbert Thiebaud
  - Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal. · Pierre-André Jacquod
    - Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal. · Michael Meeks
      - Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal. · Joachim Trémouroux
        
        Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal. · Michael Meeks
        
        Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal. · Pierre-André Jacquod
        
        Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal. · Caolán McNamara
        
        (message not available)
        
        [Libreoffice] Fwd: [patch] binfilter: cleanup and compilation warnings removal. · Norbert Thiebaud

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.