Re: [Libreoffice] [patch] binfilter: cleanup and compilation warnings removal.

Hi Joachim,

On Mon, 2010-11-22 at 13:59 +0100, Joachim Trémouroux wrote:
> I have fixed some compilation warnings in binfilter and some
> unnecessary comments. Patch is attached for review.

        Hokay - the binfilter is of course un-loved and under-maintained.

> I have two questions:
>  - /*N*/ . Should I fix them massively? I have currently left them
> unchanged to avoid a big cleanup patch.

        I guess this should be done by some large-scale sed at some point
centrally. Certainly not a useful patch for the list ;-)

>  - Unused parameters in some methods are triggering compilation
> warnings. Should I fix them by removing the parameter name ?

        Sounds reasonable.

        Really though - the binfilter is not the best place to focus cleanups
(though I appreciate it is fugly old code ;-) Most people will not want
it (only useful for decade-old binary StarOffice file formats).

        Thanks,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot