ESC meeting minutes: 2020-03-05

* Present:
    + Eike, Thorsten, Heiko, Michael S, Gabriel, Ilmari, blendergeek, Michael W, Caolan, Olivier, 
Xisco, Miklos

* Completed Action Items:
   + Update VS baseline to 2019 in git (Stephan)
   + Install current VS2019 on build bots / Jenkins (Cloph, Thorsten)
   + Enable skia by default on master and Windows, replacing GL (Lubos)

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)

* Release Engineering update (Xisco)
   + 7.0 status: feature freeze is last week of May
   + 6.4 status: 6.4.2 rc2 will be tagged next week
   + 6.3 status: 6.3.6 in April
   + Remotes
   + Android viewer: core.git java viewer is currently broken on master
     + both arch64 and x86 (crash on doc load, will investigate)
     + have 2 changes in gerrit attempting to fix these problems (Michael W)
   + Online

* Documentation (Olivier)
   + New Help
      + Some auxiliary XSLT for refactoring (ohallot)
      + refactor for readability of JS (buovjaga)
   + Helpcontents2
      + Fixes and updates for UI-HC2 better match (S. Chaiklin, M. Kaganski)
      + Some refactoring of pages (buovjaga)
      + Fixes on contents/liguistics (fitoshido, S. Schröder)
   + Guides
      + Works in progress for all guides.
      + some investigation for managing translations of Guides (WIP) (ohallot)


* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       238(238) (topicUI) bugs open, 260(260) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month    3 months   12 months
            added      6(-4)     23(-2)     47(-3)     118(-2)
        commented     79(-40)   379(-14)   994(-40)   2933(25)
          removed      1(1)       3(1)       8(0)       18(0)
         resolved     11(-10)    48(3)     103(-3)     269(2)
   + top 10 contributors:
         Heiko Tietze made 284 changes in 1 month, and 1484 changes in 1 year
         Foote, V Stuart made 75 changes in 1 month, and 530 changes in 1 year
         Dieter Praas made 70 changes in 1 month, and 429 changes in 1 year
         Roman Kuznetsov made 49 changes in 1 month, and 337 changes in 1 year
         Seth Chaiklin made 48 changes in 1 month, and 168 changes in 1 year
         Xisco Faulí made 28 changes in 1 month, and 447 changes in 1 year
         Kainz, Andreas made 27 changes in 1 month, and 286 changes in 1 year
         锁琨珑 made 27 changes in 1 month, and 34 changes in 1 year
         Timur made 18 changes in 1 month, and 146 changes in 1 year
         Cor Nouws made 17 changes in 1 month, and 175 changes in 1 year

    + New tickets with needsUXEval Feb/27-Mar/05

       * UNO command to dock all toolbars
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131005
       => WF
       * Navigate document content when selection is made in the Navigator
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131063
       => many pro and con

       * Remove "rename" option for hatch context menu and add "delete" to
         dialog box
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131036
       * What is the difference between a "Styles deck" and a "Styles window"?
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131078
       => forwarded to documentation

       * UI: Find All search result frame cannot resized
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131047
       => NEEDINFO

       * Writer table: "Number Format..." removed from context menu
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131046
       => unconfirmed

    + Some input for the branding of the upcoming release
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130778
       + cool proposals

* Crash Testing (Caolan)
   + 1(+0) import failure, 2(+0) export failures
     - mini-run, normal run blocked due to problematic HW
   + 2 coverity issues
   + 11 ossfuzz issues
   + Mozilla added a hunspell fuzzer to oss-fuzz
     + may also help with fixing the problems

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.3.4.2
        + (+221) 3050 2829 2188 3301 3769 3222 2057 984 0
    + https://crashreport.libreoffice.org/stats/version/6.3.5.2
        + (+323) 635 312 0
    + https://crashreport.libreoffice.org/stats/version/6.4.0.3
        + (-692) 8772 9464 6774 4842 419 0
    + https://crashreport.libreoffice.org/stats/version/6.4.1.2
        + (+2052) 2052 0

   + looks better than 6.4.0
     + we again only get the dynamic lib signatures
     + not sure if we need to just wait or something else is broken
       + will poke Cloph next week

* GSoC 2020 (Ilmari)
   + https://opensource.googleblog.com/2019/12/announcing-google-summer-of-code-2020.html
       + https://wiki.documentfoundation.org/Development/GSoC/Ideas
         + if you have the time, please do mentoring!
       + Student Application Period March 16 - 31, 2020
       + Application Review Period March 31, 2020 - April 27, 2020
   + students contacting potential mentors already, as usual

* easy hack future perspectives (Ilmari)
   + core devs seem to be of the opinion that difficultyInteresting should be the qualification 
threshold for GSoC
   + too late to change for 2020, but how about 2021? What does Thorsten say?
   + Muhammet proposed to have a new difficulty category. Ilmari thought it could be 
difficultyTrivial, for use with the ones like #pragma once and initializer_list ctor
     + trivial vs beginner, not clear which one is easier (Michael S)
       + can’t differentiate, either (Heiko)
     + sounds better to have difficultyMedium back
   + no rules from Google regarding that (Thorsten)
    + what is the advantage of a 3rd category? (Heiko)
      + not trivial and not challenging (Ilmari)
      + what is an example? (Ilmari)
        + most of them, unless trivial or challenging
        + could be the new default, then rank up or down if needed
        + e.g. sal_uLong → something else (Michal S)
          + but sometimes it’s more difficult
   + adding new tests and UNO commands
     + depends of if it’s copy&paste + adapt or something more complicated (Xisco)
   + approach: default to medium and it’ll be adjusted as necessary

=> no objections to make this written down / explicit

* mentoring/easyhack update
   + reviewing patches from first contributors is much appreciated (Muhammet)
   + 
https://gerrit.libreoffice.org/q/status:open+-label:Code-Review=-1+-label:Verified=-1+-ownerin:Committers

         committer...   1 week     1 month     3 months    12 months
                 open      75(2)      131(-2)     136(-4)      152(-2)
              reviews     680(68)    2516(-40)   6331(18)    23671(-80)
               merged     375(-29)   1729(90)    4546(-66)   18417(22)
            abandoned      23(-17)    119(7)      294(-10)    1007(9)
          own commits     279(-45)   1434(19)    3821(-27)   15251(8)
       review commits     103(4)      490(-20)   1329(44)     4551(37)
       contributor...   1 week     1 month     3 months     12 months
                 open       57(27)    111(4)       115(3)       117(3)
              reviews     1184(38)   4519(210)   10785(-15)   37012(294)
               merged       35(-5)    139(-31)     398(18)      906(24)
            abandoned       16(6)      36(-6)       91(10)      494(11)
          own commits       42(0)     163(-22)     429(25)     1063(32)
       review commits        0(0)       0(0)         0(0)         0(0)
   + easyHack statistics:
      needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 207(207)
      total 258(258)   assigned 22(22)   open 221(221)
   + top 10 contributors:
         Sophia Schröder made 12 patches in 1 month, and 12 patches in 1 year
         Weblate made 12 patches in 1 month, and 32 patches in 1 year
         Balazs Varga made 7 patches in 1 month, and 64 patches in 1 year
         LibreOfficiant made 7 patches in 1 month, and 87 patches in 1 year
         Marco A.G.Pinto made 6 patches in 1 month, and 15 patches in 1 year
         Pelin, Rabia Kuran made 6 patches in 1 month, and 11 patches in 1 year
         Tünde Tóth made 5 patches in 1 month, and 45 patches in 1 year
         Pranam Lashkari made 5 patches in 1 month, and 27 patches in 1 year
         Shivam Kumar Singh made 5 patches in 1 month, and 7 patches in 1 year
         Mohamed Sameh made 5 patches in 1 month, and 5 patches in 1 year
   + top 10 reviewers:
         Michael Stahl made 216 review comments in 1 month, and 1530 in 1 year
         Behrens, Thorsten made 214 review comments in 1 month, and 1398 in 1 year
         Nabet, Julien made 200 review comments in 1 month, and 2414 in 1 year
         Adolfo Jayme Barrientos made 180 review comments in 1 month, and 1024 in 1 year
         Meeks, Michael made 158 review comments in 1 month, and 892 in 1 year
         Grandin, Noel made 120 review comments in 1 month, and 1155 in 1 year
         Kaganski, Mike made 118 review comments in 1 month, and 866 in 1 year
         Holešovský, Jan made 114 review comments in 1 month, and 1013 in 1 year
         Timar, Andras made 114 review comments in 1 month, and 1275 in 1 year
         Xisco Faulí made 108 review comments in 1 month, and 920 in 1 year
   + Patches automatically abandoned:
       tdf#129342 drawinglayer: convert 16bpp formats to compatible format ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85234
       Fix typo in code ( Andrea Gelmini )
           - https://gerrit.libreoffice.org/#/c/85320
       Make SdrTableObj ctor partially skip setup before cloning ( Stepas Toliautas )
           - https://gerrit.libreoffice.org/#/c/85722
           - looks like performance-related
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Alan Tang (OSSII)
         james n

Commit Access
   + None

* Developer Certification (Stephan/Kendy/Thorsten)
   + sleep -12 weeks
   + seeking for a new person as a replacement for Bjoern, who is currently inactive

* Jenkins / CI update (Christian)
   + Missing Cloph

* l10n (Sophie)
 + working on user documentation

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia / vulkan: to try it on master (Miklos)
   + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
     + 18 bugs total (2 open)
   + Lubos is working on better text rendering (on top of harfbuzz)

* docx/xlsx competitive marketing issues (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs (0)
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs (0)
 + no change since last week

* Changing the default ‘make’ target (Lubos)
 + https://gerrit.libreoffice.org/c/core/+/89820
 + keeping ‘make check’ unchanged
 + plain ‘make’ would just build, not run tests
 + buildbot owners: need to run ‘make unitcheck slowcheck’ on Windows/macOS, not just plain ‘make’ 
to avoid loosing test coverage

* QA update (Xisco)
   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 662 (+22)
       + enhancements: 81  (+8)
       + needsUXEval: 2 (-2)
       + haveBackTrace: 1 (+0)
       + needsDevAdvice: 12 (+1)
       + documentation:  16 (+4)
       + android:  7 (-1)
       + iOS:  0 (+0)
       + Online:  12 (+2)

   + Most pressing bugs:
    New:
       + Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
           + https://bugs.documentfoundation.org/show_bug.cgi?id=116079
           + regression from the fastparser gsoc work from 2016

    Old:
       + FILEOPEN: Some labels in charts are not displayed by default
           + https://bugs.documentfoundation.org/show_bug.cgi?id=117088
           + Patch in gerrit: https://gerrit.libreoffice.org/c/core/+/89829

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone


   + New high severity bugs of the week:
        [None]

* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +168  +7 (-136) overall)
     many thanks to the top bug squashers:
      QA Administrators       11
      Heiko Tietze            9
      Xisco Faulí             8
      Caolán McNamara         7
      Julien Nabet            7
      Noel Grandin            7
      Mike Kaganski           5
      Balázs Varga            4
      László Németh           4
      Roman Kuznetsov         4

   + top 10 bugs reporters:
      Mike Kaganski           7
      NISZ LibreOffice Team   6
      Xisco Faulí             6
      sdc.blanco              6
      Regina Henschel         4
      Drew Jensen             3
      Eyal Rozenberg          3
      Heiko Tietze            3
      Caolán McNamara         2
      Elmar                   2

   + top 10 bugs fixers:
      Grandin, Noel           7
      McNamara, Caolán        7
      Heiko Tietze            6
      Balazs Varga            4
      Németh, László          4
      Kaganski, Mike          3
      Glogowski, Jan-Marek    2
      Henschel, Regina        2
      Kainz, Andreas          2
      Mehrbrodt, Samuel       2

   + top 10 bugs confirmers:
      Xisco Faulí             34
      Dieter Praas            17
      Brinzing, Oliver        10
      Heiko Tietze            9
      Bergmann, Stephan       6
      Budea, Áron             5
      Nabet, Julien           5
      *UNKNOWN*               4
      Oliver Grimm            4
      Balazs Varga            3


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 2/41 -     4 %  (+2)
    5.3 : 0/54 -     0 %  (+0)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 1/36 -     2 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/76 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 1/133 -    0 %  (+0)
    4.1 : 3/85 -     3 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 5/244 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  + 705/4029 707/4002 702/3978 708/3954 705/3930 695/3907 694/3890

    done by:
       Xisco Faulí            18
       NISZ LibreOffice Team   3
       Brinzing, Oliver        2
       Raal                    2
       Roman Kuznetsov         1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  + 882/4876 886/4850 881/4824 884/4796 878/4772 870/4750 868/4733

    done by:
       Xisco Faulí            17
       NISZ LibreOffice Team   3
       Brinzing, Oliver        2
       Raal                    2
       Roman Kuznetsov         1


* all bugs tagged with 'regression'
  + 1134(-8) bugs open of 9398(+26) total 1(+0) high prio.

    done by:
       Xisco Faulí            16
       NISZ LibreOffice Team   3
       Roman Kuznetsov         2
       Brinzing, Oliver        2
       eisa01                  1
       Raal                    1
       Robert Großkopf         1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    Calc          - 1(+0)

  by OS:
    All           - 1(+0)
    Linux         - 0(+0)
    Mac OS X      - 0(+0)
    Windows       - 0(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 314(-5)
    Calc                     - 220(-1)
    Impress                  - 132(+1)
    Writer: docx filter      - 66(-2)
    LibreOffice              - 64(+0)
    Draw                     - 45(-1)
    UI                       - 40(-2)
    Borders                  - 38(+0)
    Base                     - 35(+0)
    Writer: perf             - 35(+0)
    Crashes                  - 34(+2)
    Writer: doc filter       - 31(+1)
    Writer: other filter     - 29(+0)
    graphics stack           - 29(+1)
    RTL                      - 23(+0)
    filters and storage      - 23(+1)
    Printing and PDF export  - 21(+0)
    Chart                    - 18(+1)
    BASIC                    - 17(-1)
    framework                - 2(+0)
    Extensions               - 1(+0)
    Installation             - 1(+0)
    sdk                      - 1(+0)