Re: Some baseline thoughts

On 06/15/2017 03:45 PM, Stephan Bergmann wrote:
> On 06/15/2017 03:34 PM, Stephan Bergmann wrote:
> > If there's no objections, I'd bump current master towards LO 6.0 to 
> > GCC 4.8.
>
> (4.8.1 even, so we'll have ref-qualifiers known-working everywhere and 
> can drop HAVE_CXX11_REF_QUALIFIER.)

done now with 
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=579497164f6bddfeb14bb6b0f4b9cd3322af1803> 
"Bump GCC baseline to 4.8.1" and follow-up 
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=468fc3847cfd65217949630e2ffd9fb0a89e9cbb> 
"Work around GCC derivates with two-section 'gcc -dumpversion' output" 
(and note

> Jun 16 13:20:56 <vmiklos>       sberg: is it an overkill to compile a small test program that reads 
> __GNUC_PATCHLEVEL__ to avoid the need to assume things?
> Jun 16 13:47:43 <sberg> vmiklos, given <https://gcc.gnu.org/develop.html#num_scheme> and the 
> changed version scheme since GCC 5, I'd just leave it at that; ref-qualifiers only available in 4.8.1 seems to 
> be a rare exception where a feature only became available in a x.y.1 release, and we're still explicitly 
> checking for existence of that feature independent of the GCC version we determine

about the latter)

consequently, also did 
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=c127c19de62201b49b6647ef3ee8b08ae49da852> 
"Remove HAVE_CXX11_REF_QUALIFIER, always true now"