Sounds great to me too; though of course I'd prefer to keep the diff
smaller and not replace all the header guards:
#ifndef INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX
#define INCLUDED_OOXML_FAST_CONTEXT_HANDLER_HXX
Oh the other hand, it would be nice if the header guards were
consistently named... and didn't start with an underscore (such
identifiers are supposed to be reserved for the language and/or OS
implementation, unless I am mistaken). Somebody just needs to come up
with a consistent naming style and do it (with some nice script). (The
style of above example would be fine with me.)
Currently many of the header guards have names that indicate an
obsolete location of the header file, like _SV_SALGDI_HXX even though
the file in question is not in any "sv" folder but in vcl/inc.
Yeah, I guess such cosmetic changes can be seen as totally pointless
and a waste of time... on the other hand, if a hundred developers all
get annoyed for a few seconds once a week when they see some such
"only cosmetic" inconsistency, it all adds up, too;) Style *is*
important to make the code nicer to look at.
--tml
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.