Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way

Caolán McNamara <caolanm -AT- redhat.com>
Thu, 04 Oct 2012 12:07:55 +0100

On Thu, 2012-10-04 at 11:34 +0200, Stephan Bergmann wrote:

+        OSL_FAIL( "Out of bounds substring access" );


New code should use SAL_WARN, please.  (Arguably, it should rather use 
abort.  Which would also make the following code moot.)

+        IMPL_RTL_STRINGNAME( newFromLiteral )( ppThis, "!!br0ken!!", 10, 0 );


make it an assert, but leave the following code in for the NDEBUG case ?

C.

Context

Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Stephan Bergmann
- Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Norbert Thiebaud
  - Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Stephan Bergmann
- Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Caolán McNamara
- Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Michael Meeks
  - Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Norbert Thiebaud
  - Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Bjoern Michaelsen
    - Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Lubos Lunak
    - Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Michael Meeks
      - Re: [Libreoffice-commits] update string copy semantics to be undefined in a non-crashing way · Bjoern Michaelsen

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.