Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index



On Thu, 2012-10-04 at 11:34 +0200, Stephan Bergmann wrote:
Given that "it is an error for X to happen" and "if X happens, behaviour 
is undefined" have exactly the same meaning (at least in my 
understanding of computing), I wonder whether this is just a harmless 
rephrasing, or whether there is a deeper misunderstanding lurking there.

        Well - there was a very complicated semantic discussion in the ESC that
I must confess I didn't fully grasp the import of. This patch was the
result.

+    {
+        OSL_FAIL( "Out of bounds substring access" );

New code should use SAL_WARN, please.  (Arguably, it should rather use 
abort.  Which would also make the following code moot.)

        The arguably bit was near the crux of the discussion - IIRC it was
decided that aborting was not a great idea - we have enough odd
corner-case bugs crawling out of the woodwork just now. The SAL_WARN
thing sounds sensible - I'd really appreciate it if someone that
understands the full set of all the warn / log variant macros, and also
likes using stream operators could work out how to print something more
meaningful about the error :-) preferably un-conditionally - so no
environment variable is needed etc. [ is that a SAL_WARN? ].

Oh, what should have been a linear list of versions turned into a 
multi-pronged fork starting with LIBO_UDK_3.5.  Fixed that now for 
LIBO_UDK_3.7 at least.

        Heh ;-) great. I copied the existing pattern, odd as it looked; thanks
for fixing.

        ATB,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.