Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Wed, Jul 25, 2012 at 4:53 PM, Michael Stahl <mstahl@redhat.com> wrote:
On 25/07/12 23:35, Norbert Thiebaud wrote:
On Wed, Jul 25, 2012 at 3:09 PM, Michael Stahl <mstahl@redhat.com> wrote:
the problem with the duplication is that the next time somebody fixes a
problem with the "dev-install" target they will probably forget to fix
the "install-tb" target as well, and if the problem affects tinderboxes
as well then they will remain broken.  whether that is more likely, or
whether a change to --disable-linkoo is more likely, is of course
speculative.

True...
There is one aspect we missed... install-tb does _not_ depend on the
'build' target (and no -o build did not prevent the whole shebang to
be built)

yes, the problem is that make does not propagate some options like -W
and -o to sub-makes, and the top-level Makefile only handles rebuilding
configure; the workaround is to invoke it like this:

make -f Makefile.top dev-install -o build

Thanks, good to know... but let me ask you then:
what is more likely:
- that someone changed the way that dev-install works in the Makefile
and missed install-tb in the same make file a bit below...
or
- that someone change how the Makefile recursion thingy works and
forget to update bin/tinbuild_phases.sh (*) in the contrib/buildbot
repo ?

:-D

Norbert

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.