Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review

Hi Tor,

On Tue, Jun 19, 2012 at 10:14:27PM +0300, Tor Lillqvist wrote:
> But if the intent is that *all* changes are to go through gerrit,

Its not. As said repeatedly on this thread already, everyone who has an fd.o
account will be able to continue to push to master. However, the hope is that
the convenience of having a windows build before it hits master and being able
to fix it without time pressure and 20 angry other devs shouting at you on IRC
will convince you to use it for more and more stuff.

> surely the majority of changes (number-of-lines-wise, not number-wise) going
> through it will be feature work and cleanups, not patches?

Once we tune the tinderboxes to build stuff submitted to review there, having
these build will be quite nice esp. for features etc. And if your patch is in
danger of rotting away with nobody giving it love, the tinderboxes where happy
with it, you can still push it directly to master on you own risk. But even
there, I think asking another dev on IRC "hey Im confident with that, the
tinderboxes are fine with it, could you give it a quick review otherwise I
would push myself" would give you what you want. Its all checks and balances:
Nobody will be powerplayed and not get his stuff in, but there still might
someone else at least skimming over it in addition now.

Its a bit different for those who do not have direct commit access -- they can
only hope for somebody reviewing and pushing their change. But that is also not
different from before for them. If anything changes, its that we can give them
direct commit access quicker and with less hassle now. OTOH, the hope is, that
the urgent need for that is shrinking too anyway.

> Will this mean people will start doing less refactoring cleanups, for
> instance, in order to make their change sets smaller, to increase the
> possibility of somebody reviewing the, eh, "patch"?

No.

Best,

Bjoern