Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review

Bjoern Michaelsen píše v Út 19. 06. 2012 v 13:38 +0200:
> On Tue, Jun 19, 2012 at 11:13:45AM +0200, Petr Mladek wrote:
> > It means that gerrit should be able to detect patches for review on the
> > mailing list, integrate them, and make them ready for review.
> >
> > My expectation would be that it sends a replay to the mailing list with
> > a link to diff, link to build results and commands to approve it.
>
> Please provide constructive feedback to for example:
>
>  https://bugs.freedesktop.org/show_bug.cgi?id=51159

Ah, this bug is about a daily digest. I think that we first need to
decide how much we want to modify the current work flow. Do we want to
really move most discussions from the mailing list to gerrit?

How people will be noticed about news in gerrit? Is one day digest
really enough?

Also, you know, there is the "hello/thanks/see you" much more involved
in the mailing list. I think that such things are important for the
community live.

Note that the cooperation with mailing list is even in the plan, see:

        + setup mail notifications to the developer mailing list
        + setup patch drop mailbox
        + scripting to automagically identify patches on the mailing
          list

at
http://wiki.documentfoundation.org/Development/GerritMigration#Action_items


I think that gerrit should send mail to the mailing list immediately
when someone needs review (people without commit access, people that are
not sure about their fix).

For inspiration, I attach mail from the openSUSE Build Service. It
includes:

        + description of changes
        + diff of the spec file
        + commands how to get full diff, approve or reject the change



>  http://nabble.documentfoundation.org/gerrit-for-release-branches-bots-ftw-tp3990804.html

I am going to answer it but I am busy with some other things.

> implementing this "into the blind" just for it to be rejected by those who
> where silent before is not the way to go.

I think that my request is nothing new for you. I think that it was
actually one of the most important requests since the beginning.


Best Regards,
Petr

--- Begin Message ---

• fstrba -AT- novell.com
• Mon, 11 Jun 2012 12:40:47 +0000

   home:fstrba/libcdr -> devel:libraries:c_c++/libcdr


   https://build.opensuse.org/request/show/124460

   Description: New upstream release

changes files:
--------------
--- libcdr.changes
+++ libcdr.changes
@@ -1,0 +2,7 @@
+Mon Jun 11 14:32:55 CEST 2012 - fridrich.strba@suse.com
+
+- Update to upstream version 0.0.8
+  * initial text support
+- Remove upstreamed patch
+
+-------------------------------------------------------------------

old:
----
  libcdr-0.0.7-clang.patch
  libcdr-0.0.7.tar.xz

new:
----
  libcdr-0.0.8.tar.xz

spec files:
-----------
--- libcdr.spec
+++ libcdr.spec
@@ -28,13 +28,12 @@
 BuildRequires:  gcc-c++ pkgconfig xz zlib-devel liblcms2-devel
 BuildRequires:  libwpd-devel >= 0.9.0 libwpg-devel >= 0.2.0 
 Summary:        Library for parsing the Corel Draw file format structure
-Version:        0.0.7
+Version:        0.0.8
 Release:        0
 License:        LGPLv2+, GPLv2+, MPL1.1
 Group:          Productivity/Publishing/Word
 Url:            http://www.freedesktop.org/wiki/Software/libcdr
 Source:         http://dev-www.libreoffice.org/src/libcdr-%{version}.tar.xz
-Patch0:         libcdr-0.0.7-clang.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 
 %description
@@ -86,7 +85,6 @@
 
 %prep
 %setup -q
-%patch0 -p1
 
 %build
 %configure --disable-static --docdir=%_docdir/%name

other changes:
--------------

++++++ libcdr-0.0.8.tar.xz (new)

++++++ deleted files:
--- libcdr-0.0.7-clang.patch
--- libcdr-0.0.7.tar.xz


To REVIEW against the previous version:
   osc request show --diff 124460

To ACCEPT the request:
   osc request accept 124460 --message="reviewed ok."
   
To DECLINE the request:
   osc request decline 124460 --message="declined for reason xyz (see ... for background / policy / 
...)."

To REVOKE the request:
   osc request revoke 124460 --message="retracted because ..., sorry / thx / see better version ..."
-- 
Hermes messaging (http://hermes.opensuse.org)
openSUSE Build Service (https://build.opensuse.org/)
Collaboration: http://en.opensuse.org/Build_Service/Collaboration

--- End Message ---