Re: [ANN] Please use Gerrit from now on for Patch Review

Norbert Thiebaud <nthiebaud -AT- gmail.com>
Tue, 19 Jun 2012 06:54:54 -0500

On Tue, Jun 19, 2012 at 4:54 AM, Jan Holesovsky <kendy@suse.cz> wrote:

I would be happy.  But is it going to be so?  So far the best I've got
from gerrit was clicking [Diff all unified], that opened one browser
window per file (ugh!), with more clicking to actually do the review.


We added gitweb in gerrit so for example:

on the page

https://gerrit.libreoffice.org/#/c/222/

if you click on the (gitweb) link, next to 'Patchset 1 <sha>'

you'll get to
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=7660799346bb846890eb08e556933b5850158e0d
and to
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=7660799346bb846890eb08e556933b5850158e0d

(maybe we can make it go to commit-diff directly... to be investigated)

Norbert

Context

Re: [ANN] Please use Gerrit from now on for Patch Review (continued)
- Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · Petr Mladek
  - Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · Bjoern Michaelsen
    - Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · Petr Mladek
      - Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · Bjoern Michaelsen
        
        Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · Petr Mladek
        
        Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · Bjoern Michaelsen
        
        Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · Tor Lillqvist
        Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · Bjoern Michaelsen
        
        Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · David Ostrovsky
        
        Re: [libreoffice-projects] [ANN] Please use Gerrit from now on for Patch Review · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.