Re: [ANN] Please use Gerrit from now on for Patch Review

Hi Bjoern,

On 2012-06-19 at 13:03 +0200, Bjoern Michaelsen wrote:

> > If you answer was that the new workflow would be:
> >
> > - click a link in a mail from gerrit
> >   - that will open the syntax-highlighted cgit-like patch in the
> >     browser, on a page with a big [Push it!] button + space to write the
> >     "Thank you" message
> > - I write the "Thank you" message + hit the [Push it!] button
> >
> > I would be happy.  But is it going to be so?  So far the best I've got
> > from gerrit was clicking [Diff all unified], that opened one browser
> > window per file (ugh!), with more clicking to actually do the review.
>
> That will be the workflow in the end (when gerrit owns the repo). As for seeing
> the diff: we now have gitweb integrated there(*), so ignore "Diff all unified" and
> just use the "gitweb" links (see here: https://gerrit.libreoffice.org/#/c/179/).
>
> Then click on "review" select  "+1 verified/+2 code-review", write thank you
> below and it will be cherry-picked on master and the submitter will get a mail.

Great, thank you, now we are getting somewhere :-)  So how do we deal
with the usability improvements here?  [Eg. to remove the unhelpful
"Diff all unified" button, or tweak it to point to cgit or gitweb;
removing unnecessary stuff not to overwhelm people; etc.]

> The second step however does not yet work as long as gerrit does not own the
> repository. Thats why it is so damn important, that everyone gets his gerrit
> account set up as requested a month ago, so that we can switch over completely.

"damn important" will not get you there, I am afraid - only explaining,
and making it no harder than the current workflow will do.

> (*) Big Thanks to Robert Einsle for that!

Thanks Robert for doing that!  Please - is there any chance to use cgit
instead, so that it is compatible / familiar with the freedesktop
browsing?

Thank you,
Kendy