RE: [PATCH]fdo45671 writer par. bg color simplified code for split button

Winfried Donkers <W.Donkers -AT- dci-electronics.nl>
Tue, 6 Mar 2012 08:50:59 +0100

Ivan Timofeev wrote (5 maart 2012 18:08)

1. Open a new Writer doc
2. Type smth
3. Press the "Background Color" button
   -> nothing happens (?)

That is expected behaviour to me. The startup background colur is transparent (hence the gray 
bitmap in the button).

4. Select some color from the picker
   -> ok, it works
5. Select "No Fill"
   -> nothing happens

That is not OK.
I put back the original (pre fdo44611 patch) code and that restored the wanted behaviour.
Do you want me to submit a separate fix for this (easiest for me) or do you wanty me to resubmit 
the patch (which will have to wait till the end of the day then and will need some experimenting 
with git)?
Thank you for being critical :)

Winfried

Context

[PATCH]fdo45671 writer par. bg color simplified code for split button · Winfried Donkers
- Re: [PATCH]fdo45671 writer par. bg color simplified code for split button · Ivan Timofeev
  - RE: [PATCH]fdo45671 writer par. bg color simplified code for split button · Winfried Donkers
    - Re: [PATCH]fdo45671 writer par. bg color simplified code for split button · Ivan Timofeev
      - RE: [PATCH]fdo45671 writer par. bg color simplified code for split button · Winfried Donkers
        
        Re: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Ivan Timofeev
        
        Re: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Stefan Knorr (Astron)
        
        RE: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Winfried Donkers
        Re: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Stefan Knorr (Astron)
        RE: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Winfried Donkers
        RE: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Winfried Donkers
        RE: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Winfried Donkers
        RE: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Winfried Donkers
        Re: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Stefan Knorr (Astron)
        RE: [PUSHED][PATCH]fdo45671 writer par. bg color simplified code for split button · Winfried Donkers

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.