Re: [PUSHED 3.5] fix for fdo#46975 , crash when using mouse wheel in input line

Noel Power <nopower -AT- suse.com>

Tue, 06 Mar 2012 09:36:08 +0000

Hi Markus On 06/03/12 00:28, Markus Mohrhard wrote:

Hey,

[1] fixes a crash when you use the mouse wheel while a formula is in
the selected cell. We should not handle the mouse wheel event for the
input line.

I think this patch is safe. I did not move the handling of the event
to the parent window because this would result in scrolling through
the document even if you are over the input line.

Regards,
Markus

[1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=77a517a467b3aa944e31b170162518f70da3793d

I think it looks ok, I wonder though what changed?, I suppose pEditView

is now set where previously it wasn't ( a side effect of the multiline

input stuff ). I worry though there might be other events that might

cause problems and also need to be ignored :/ Anyway I cherry-picked it

to 3.5

Noel

Context

[REVIEW] fix for fdo#46975 , crash when using mouse wheel in input line · Markus Mohrhard

Re: [PUSHED 3.5] fix for fdo#46975 , crash when using mouse wheel in input line · Noel Power

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.