Re: [Libreoffice] [PATCH] Base fdo#40079 "file / save (as)" inoperant

probably I should have read further before replying ;-) ( sorry excuse 
for a mind is elsewhere at the moment )
On 15/08/11 13:10, Lionel Elie Mamane wrote:
> So probably what happened is that the "// Can we simply copy the
> storage?" optimisation / fast path was added and suddenly
> SfxLibraryContainer::storeLibrariesToStorage does not anymore load the
> libraries, as the rest of the code in
> SfxDialogLibraryContainer::storeLibrariesToStorage expected, which
> would suggest that my patch is the right fix.
this sounds very plausible
> The remaining question is: if xSourceLibrariesStor->copyElementTo was
> called, does the code under:
>
>      // we need to export out any embedded image object(s)
>      // associated with any Dialogs. First, we need to actually gather any such urls
>      // for each dialog in this container
>
> still need to be run? In other words, has copyElementsTo copied these
> embedded image objects, or not?
not at all sure  but it should be easy enough to test, in your dialog 
create an image control, right click to get the property sheet for the 
control, under the general tab scroll down to the Graphics property, 
click on the '...' to select a graphic, make sure you unselect the 
'link' check box to ensure the image is embedded. After saving, the 
image should be stored in it's own document stream. After testing with 
your 'modification' scenario ( e.g. run macro, make change, re-save ) 
when you open the dialog the image should be still there ( best of 
course to check that after restarting libreoffice and re-opening the 
document )


Noel