Re: [Libreoffice] [PATCH] Base fdo#40079 "file / save (as)" inoperant

On Wed, Aug 17, 2011 at 09:48:04AM +0100, Noel Power wrote:
> On 16/08/11 17:32, Lionel Elie Mamane wrote:

> > > Two questions,
> > > a) did you try this on master
> > No, not yet.
> no problem

I did now. Reproduced there, but someone (you?) pushed my patch so
*now* one cannot reproduce it anymore.

I also took the liberty of adding you to the CC list for the bug. I
did not go as far as assigning it to you ;-)

> > > ( I did and it appeared to work as expected ) but I am pretty
> > > 'base' disabled so I fear I may have missed something in trying to
> > > recreate it


> I think I did it right then, but..

I added a testcase file and *very* detailed instructions to the bug.

> > Which leads me to another bug: If I remove the librarie's only dialog
> > and save, I restart LO, I reopen the file again, the dialog is
> > back.

> probably worth opening another bug for that then, anyway, lets look
> at one thing at a time ( otherwise I will get depressed )

Fixed (by me) in master.

> > > b) is this behaviour specific to base documents?

> > Well, this bug is, but that is because the other apps have another
> > bug that hides this one :-(

> > My testing shows that
> > SfxDialogLibraryContainer::storeLibrariesToStorage aborts at the
> > same place for a calc document (an exception is raised), but this
> > does not abort the save. Thus, logically, in the conditions where
> > this bug shows up, Calc looses the embedded images

Fixed (by me) in master for calc and writer, commit
7f3a944146879d2f0e6ee3f69cf721eb14f18689. I notice that calc and
writer have the good sense of displaying an error message when an
exception is raised during save. That's better than Base, that just
silently aborts the save with no error message.

However, calc seems to get very confused and disables (greys out) the
save, close file, quit application, etc features :-|

-- 
Lionel