Re: [Libreoffice] [PATCH] Base fdo#40079 "file / save (as)" inoperant

Hi Lionel
On 16/08/11 17:32, Lionel Elie Mamane wrote:
> > Two questions,
> > a) did you try this on master
> No, not yet.
no problem
> > ( I did and it appeared to work as expected ) but I am pretty 'base'
> > disabled so I fear I may have missed something in trying to recreate
> > it
> You have to be very cautious what you do to reproduce it, it is
> fragile: for example, if you open the Basic IDE, you have lost, as
> this, according to my testing, leads to the Dialog library having been
> loaded at the point I patch.
I think I did it right then, but.. ok worth trying again I suppose, also 
I rebuilt a fresh 3.4 that at least can now open a database file so I 
will try there again with the same instructions
> lso should not be empty; it should
> contain at least one dialog.
>
> Which leads me to another bug: If I remove the librarie's only dialog
> and save, I restart LO, I reopen the file again, the dialog is
> back. If the library has two dialogs and I delete one, it is gone
> after a save and reload. This seems to be Base-specific.
probably worth opening another bug for that then, anyway, lets look at 
one thing at a time ( otherwise I will get depressed )
> > b) is this behaviour specific to base documents?
> Well, this bug is, but that is because the other apps have another bug
> that hides this one :-(
>
> My testing shows that
> SfxDialogLibraryContainer::storeLibrariesToStorage
> aborts at the same place for a calc document (an exception is raised),
> but this does not abort the save. Thus, logically, in the conditions
> where this bug shows up, Calc looses the embedded images
what are the steps to reproduce this? ( hopefully it is reproducible ) 
this sounds bad
> in
> Dialogs. This is tested. And I guess also looses (the changes to?)
> anything that is saved *after* the Dialogs, if anything is (this is
> not tested).
thanks again
Noel