Re: [Libreoffice] [REVIEW] - cherrypick to 3.4.3 Base fdo#40079 "file / save (as)" inoperant

Jan Holesovsky <kendy -AT- suse.cz>
Mon, 22 Aug 2011 14:24:09 +0200

Hi Lionel,

On 2011-08-21 at 08:36 +0200, Lionel Elie Mamane wrote:

I'm unsure whether the acks needed for cherrypick are "any committer"
or a more restricted group, but in case it is the former: I agree that
commit 03e9161e2eca9d389d7ce419495538c31f6aed31 is worthwhile to
cherrypick for 3.4.3, as:


Any developer counts, so you are welcome to review patches!  Only in
this case, you are the author of the patch - a self-review does not
count ;-)

But please feel encouraged to review other patches that need 3 reviews.
A good review consists of not only a kind of "approved" message, but
also of an explanation why the change is safe (which is what you've
provided, so you did what is expected).

Thank you,
Kendy

Context

Re: [Libreoffice] [PATCH] Base fdo#40079 "file / save (as)" inoperant (continued)
- Re: [Libreoffice] [PATCH] Base fdo#40079 "file / save (as)" inoperant · Noel Power
- Re: [Libreoffice] [PUSHED] - cherrypick to 3.4.2 Base fdo#40079 "file / save (as)" inoperant · Noel Power
  - Re: [Libreoffice] [REVIEW] - cherrypick to 3.4.2 Base fdo#40079 "file / save (as)" inoperant · Noel Power
    - Re: [Libreoffice] [REVIEW] - cherrypick to 3.4.2 Base fdo#40079 "file / save (as)" inoperant · Michael Meeks
      - Re: [Libreoffice] [REVIEW] - cherrypick to 3.4.3 Base fdo#40079 "file / save (as)" inoperant · Noel Power
        
        Re: [Libreoffice] [REVIEW] - cherrypick to 3.4.3 Base fdo#40079 "file / save (as)" inoperant · Lionel Elie Mamane
        
        Re: [Libreoffice] [REVIEW] - cherrypick to 3.4.3 Base fdo#40079 "file / save (as)" inoperant · Jan Holesovsky
        
        [Libreoffice] [META] nitpicking on cherry-picking review rules · Lionel Elie Mamane
        Re: [Libreoffice] [META] nitpicking on cherry-picking review rules · Petr Mladek
  - Re: [Libreoffice] [PUSHED] - cherrypick to 3.4.3 Base fdo#40079 "file / save (as)" inoperant · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.