Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1

Dnia 2011-08-07, nie o godzinie 21:31 +0200, Eike Rathke pisze:
> I suggest
>
> ::std::vector<sal_uInt32>::iterator GetAdded_Impl( size_t nKey );
>
> with logically the content of IsAdded_Impl() but using ::std::find()
> instead of the awkward loop and returning the position's iterator that
> can be used in RemoveFormat(), plus
>
> bool IsAdded_Impl( size_t nKey )
> {
>     return GetAdded_Impl( nKey) != aAddList.end();
> }
>
> for all other places that need only a bool to remain the same.

Okay.


> > in next patch I will try to change short to appropriate type and in other places try to use 
> > size_t.
>
> Take care not to touch too much, some of the short type seems to evolve
> from the list box using that type for position of elements. I think it
> doesn't pay to be overly aggressive there.

So I have tried to do this, but it is like Domino.