Re: [Libreoffice] signed/unsigned comparison

Eike Rathke <ooo -AT- erack.de>
Tue, 9 Aug 2011 15:12:49 +0200

Hi Stephan,

On Tuesday, 2011-08-09 09:05:49 +0200, Stephan Bergmann wrote:

On Aug 6, 2011, at 3:32 PM, Maciej Rumianowski wrote:

@@ -1325,7 +1288,7 @@ String SvxNumberFormatShell::GetComment4Entry(short nEntry)
    if(nEntry < 0)
        return String();

-    if(nEntry<aCurEntryList.Count())
+    if(nEntry < (short)aCurEntryList.size())
    {


5. Should short type be replaced with sal_Int16 or more appropriate type?


Some C++ compilers warn about comparisons like (x < y) where x is an rvalue of a signed integral 
type and y is an rvalue of an unsigned integral type.


The actual code committed has

    if( static_cast<size_t>(nEntry) < aCurEntryList.size())


  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpP46s7q21wn.pgp
Description: PGP signature

Context

Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1 (continued)
- [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Stephan Bergmann
  - Re: [Libreoffice] signed/unsigned comparison · Eike Rathke
  - Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Lubos Lunak
    - (message not available)
      - Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Lubos Lunak
        
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Stephan Bergmann
        
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Lubos Lunak
        
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Stephan Bergmann
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Lubos Lunak
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.