Re: [Libreoffice] [PUSHED] Replace SvULongs with vector and code clean up part 1

Eike Rathke <ooo -AT- erack.de>
Mon, 8 Aug 2011 11:41:20 +0200

Hi Maciej,

On Sunday, 2011-08-07 17:04:49 +0200, Maciej Rumianowski wrote:

From ba07b8f694f9736b9c43dc3f0a34d1248d8fcd77 Mon Sep 17 00:00:00 2001

From: Maciej Rumianowski <maciej.rumianowski@gmail.com>
Date: Sun, 7 Aug 2011 16:46:17 +0200
Subject: [PATCH] Replace SvULongs with vector and code clean up

Instead of SvULongs use std::vector<sal_uInt32>
replace sal_Bool with bool where variable is not interfering with return value


Pushed to master with the change mentioned in my other mail and one
nitpick:

--- a/svx/inc/svx/numfmtsh.hxx
+++ b/svx/inc/svx/numfmtsh.hxx
-    sal_uInt32          GetUpdateDataCount() const;
+    size_t GetUpdateDataCount() const;


Please preserve alignments of method names if the header file provided them.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1be3dab3d37b74570b49d8534c4d2677a318286

Thanks
  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpYDfkmRKQem.pgp
Description: PGP signature

Context

[Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1 · Maciej Rumianowski
- Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1 · Eike Rathke
  - Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1 · Maciej Rumianowski
    - Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1 · Eike Rathke
      - Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1 · Maciej Rumianowski
        
        Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1 · Eike Rathke
        
        Re: [Libreoffice] [PATCH] Replace SvULongs with vector and code clean up part 1 · Maciej Rumianowski
        
        [Libreoffice] [PATCH] Use STL find() in SvxNumberFormatShell · Maciej Rumianowski
        
        [Libreoffice] [PUSHED][PATCH] Use STL find() in SvxNumberFormatShell · Caolán McNamara
        
        Re: [Libreoffice] [PUSHED] Replace SvULongs with vector and code clean up part 1 · Eike Rathke
        
        Re: [Libreoffice] [PUSHED] Replace SvULongs with vector and code clean up part 1 · Eike Rathke
- [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Stephan Bergmann
  - Re: [Libreoffice] signed/unsigned comparison · Eike Rathke
  - Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Lubos Lunak
    - (message not available)
      - Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Lubos Lunak
        
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Stephan Bergmann
        
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Lubos Lunak
        
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Stephan Bergmann
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Lubos Lunak
        Re: [Libreoffice] signed/unsigned comparison (was: [PATCH] Replace SvULongs with vector and code clean up part 1) · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.