Re: [libreoffice-l10n] Translations getting reverted in the 25.2 branch

Christian Lohmaier kirjoitti 14.1.2025 15:33:
> Hi *,
>
> in general looking into those things it is always easier to have
> concrete pointers...

Hi Christian,

Thanks for investigating. For a concrete example in the 25.2 branch, 
see: 
https://translations.documentfoundation.org/translate/libo_ui-25-2/sdmessages/fi/?checksum=139146580d1be9fc

And for the 24.8 branch: 
https://translations.documentfoundation.org/translate/libo_ui-24-8/swmessages/fi/?checksum=7dce2525ce6ee8fc

Other cases can be found on the Changes pages:
https://translations.documentfoundation.org/changes/browse/libo_ui-25-2/-/fi/
https://translations.documentfoundation.org/changes/browse/libo_ui-24-8/-/fi/

Tuomas

> On Sat, Jan 11, 2025 at 9:54 PM Stanislav Horáček
> <stanislav.horacek@gmail.com> wrote:
> > I can confirm this: for the UI part, we had 25.2 branch fully
> > translated, however now Weblate shows 298 untranslated strings. No
> > such case occurred in the 24.8 branch.
> >
> > Could Weblate admins investigate this? This would lead to missing
> > translations in the 25.2 release.
>
> Unfortunately it doesn't seem to be obvious what exactly caused the
> issue. Illustrating with a concrete example:
>
> https://translations.documentfoundation.org/translate/libo_ui-25-2/cuimessages/cs/?checksum=b6100f3faf805f7f
>
> If you switch onto the history tab you see it being translated two
> weeks ago on 2024-12-27 and then the translation got removed by the
> system with "String updated in the repository" on 2025-01-07 / a week
> ago.
>
> While there was a template update that day that bumped (and
> auto-translated) the copy-right year in three strings - that change
> didn't touch the Formulas Calculate string, not even the context or
> file lines.
>
> https://github.com/LibreOffice/translations-weblate/commit/850b216b35443c00e2856f6f4bcab2efd836df8a
> Since github has issues with large commits here change itself for the
> file in question:
>
> $ git show 850b216b35443c00e2856f6f4bcab2efd836df8a cs/cui/messages.po
> commit 850b216b35443c00e2856f6f4bcab2efd836df8a
> Author: Christian Lohmaier <cloph@documentfoundation.org>
> Date:   Tue Jan 7 15:37:50 2025 +0100
>
>     update templates for 25-2 (includes bump of copyright year)
>
> diff --git a/cs/cui/messages.po b/cs/cui/messages.po
> index 03ab36f26aa..094d22caa67 100644
> --- a/cs/cui/messages.po
> +++ b/cs/cui/messages.po
> @@ -3,7 +3,7 @@ msgid ""
>  msgstr ""
>  "Project-Id-Version: PACKAGE VERSION\n"
>  "Report-Msgid-Bugs-To:
> https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice&bug_status=UNCONFIRMED&component=UI\n";
> -"POT-Creation-Date: 2024-12-18 19:43+0100\n"
> +"POT-Creation-Date: 2025-01-07 15:26+0100\n"
>  "PO-Revision-Date: 2024-07-11 01:45+0000\n"
>  "Last-Translator: Stanislav Horáček <stanislav.horacek@gmail.com>\n"
>  "Language-Team: Czech
> <https://translations.documentfoundation.org/projects/libo_ui-master/cuimessages/cs/>\n"
> @@ -1955,11 +1955,11 @@ msgctxt "RID_SVXSTR_CANNOTCONVERTURL_ERR"
>  msgid "The URL <%1> cannot be converted to a filesystem path."
>  msgstr "URL <%1> nelze převést na cestu souborového systému."
>
> -#. SHEvj
> +#. TtFRR
>  #: cui/inc/strings.hrc:357
>  msgctxt "aboutdialog|copyright"
> -msgid "Copyright © 2000–2024 LibreOffice contributors."
> -msgstr "Copyright © 2000–2024 přispěvatelé LibreOffice."
> +msgid "Copyright © 2000–2025 LibreOffice contributors."
> +msgstr "Copyright © 2000–2025 přispěvatelé LibreOffice."
>
>  #. WCnhx
>  #: cui/inc/strings.hrc:358
> $
>
> Now regardless of whether the translation got reverted or not, there's
> the question of: Why didn't weblate commit the translation to the
> file/the repository?
>
> https://github.com/LibreOffice/translations-weblate/commits/850b216b35443c00e2856f6f4bcab2efd836df8a/cs/cui/messages.po
>
> The commit prior to the translation touching the file was on Dec 18,
> but weblate is supposed to commit pending changes after 24h and if you
> look at the overall history it did so for other changes
> https://github.com/LibreOffice/translations-weblate/commits/libreoffice-25-2/
> Due to a change in the squash plugin handling (the one that combines
> multiple changes into a single commit), the changes were committed
> even more frequently than before (or rather in more separate commits)
>
> So there are three issues that can be made out here:
> * weblate not committing the change to the repository
> * weblate bogusly detecting the source string as changed/updated in
> the repository despite being the same string
>   (weblate showing the full history shows that it still matches the
> context/file location, so it is the same string, it treats it as if
> the source-string changed)
>   * weblate clearing the translation - even if a file is updated and
> would add changed strings, translations not submitted to the
> repository yet shouldn't get discarded, but of course that ties into
> weblate thinking the string did change...
>
> Now if the complete mechanism for the 25-2 branch was broken, then
> it'd be easy to point at a general issue, but there's really no
> explanation as to why submitting the changes did work for other
> strings, but not for the one in the example.
>
> Also I try to explicitly prevent the case of pending/unsubmitted stuff
> while updating against new templates by locking the components in
> question, manually triggering a commit of pending changes to the
> repository and only then actually updating the files.
>
> So for now it is just a guess, but it could be that locking the
> components acts differently now and also prevents syncing the pending
> files to disk/the repository, and since the repository doesn't have a
> translation, it might treat the file with an untranslated string as a
> request to clear a translation (certainly unintentional when updating
> from the repository, and even when a translator updates files you'd
> have to explicitly check to overwrite existing translations)
>
> I fear that's all I can say about this issue now - and for future
> updates against templates I'll trigger "commit pending", only then
> lock, commit again for good measure, update the repo to reduce the
> risk from that happening again.
>
> And especially since it only happened on the 25-2 branch, but not on
> the 24-8 branch that had the same copyright-year-bump change with
> auto-translation also makes me think it is a one-time fluke.
>
> The flipside is that the translations are not gone completely, but at
> least appear in translation memory and can be applied from there or
> are available in history and clearing the translation can be done from
> there.
>
> If you have examples from other strings that don't match the above
> explanation, i.e. were removed but not because the file was updated
> with the last update on Jan 7, then please provide examples, (using
> the permalink feature please, clicking the chain symbol in the
> "Translation" header-box)
>
> > (A side note: interestingly, the 25.2 branches in Weblate are visible
> > only for signed in users - is there any reason for that?)
>
> Oversight / reducing visibility when the branch was created/the files
> were imported to weblate (in fact it is already our permissions from
> importing pootle that are wrong as also regular translators shouldn't
> be able to see the projects during that time so there are less
> conflicts when I do a final sync with master translations that might
> have happened in the meantime before actually updating the branches
> with different set of templates corresponding to their respective
> branch.
>
> ciao
> Christian

--
To unsubscribe e-mail to: l10n+unsubscribe@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/l10n/
Privacy Policy: https://www.documentfoundation.org/privacy