Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index


Hi,

[ Please let's keep the discussion on the list. ]

On Thu, Jan 17, 2019 at 10:30:11PM +0000, Дилян Палаузов <dilyan.palauzov@aegee.org> wrote:
upstream fx_codec_jpeg.cpp does not exist anymore, it is called now ccodec_jpegmodule.cpp.  This 
will make backporting
of the changes in fx_codec_jpeg.cpp, used by LibreOffice, unlikely.  Besides, upstream the change 
may never be applied.

Upstream may have good reasons for not accepting your patch in its
current form, it's their decision. We usually respect upstream's
decision in this regard. Especially given that pdfium is not a dead
upstream.

As mentioned before, there is a significant maintenance cost of custom
patched externals, I would like to avoid it, based in the painful
experience of cutting down heavily patched pdfium and xmlsec to ~0
patches in the recent past.

Towards which version of pdfium shall the patch in external/pdfium be generated?

See download.lst in the toplevel directory, currently we bundle pdfium
3667 on LO master, which isn't too old, it's from 2019-01-09.

Regards,

Miklos

Attachment: signature.asc
Description: Digital signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.