Hi,
On Tue, Jan 03, 2017 at 01:05:59PM +0100, Michael Stahl wrote:
that is a valid use case for submitting something with a -1 self-review.
Whops, yes. I overlooked that you changed to explicitly marking incomplete
changes to CR-1 (instead of having them at CR0). So sorry about the ranting --
yes, having WIP changes should be ok as long as they come with a self-inflicted
-1 (or -2).
As long as Code-Review=0 only contains stuff that really needs a review, its
fine.
Sorry about the noise.
Best,
Bjoern
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.