Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index


Hi,

On Tue, Jan 03, 2017 at 10:34:27AM +0000, Kaganski Mike wrote:
But I suppose a better thing is to mark it -1 in the beginning, and revert to 0 when ready.

No. No, no, no.

Very explicitly: NO!

Dont do that. In fact, be prepared that if you push stuff that is unfit to be
merged to gerrit _others_ will mark it as CR-2 to save themselves from the
noise. They have every right to do so: The social contract of gerrit is: if you
push something there, you ask for a review.

Breaking that social contract is a very Bad Thing(tm).

Again: DONT DO THAT.

Best,

Bjoern

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.