Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index


On 1/3/2017 1:17 PM, Kaganski Mike wrote:
Sometimes, a patch that was thought by me as a correct patch (ant dso was submitted for review), 
turns out to need some rework; and then it goes through numerous iterations until it gets ready. I 
don't expect initial (or other) reviewers to spend their time to review each iteration, and I don't 
know of a way to make already submittes change s draft (except resubmitting another change, which 
isn't always desirable); so when ready, I mark it "CR+1" - i.e. fine with me, but needs other's 
review, with accompanying comment that now I regard it ready and ask others to do actual review. As 
gerrit explicitly tells that it's what CR+1 means, I don't think it's a fancy thing.

But I suppose a better thing is to mark it -1 in the beginning, and revert to 0 when ready.

--
Best regards,
Mike Kaganski

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.