Re: pushing patches despite requests for a test

Miklos Vajna <vmiklos -AT- collabora.co.uk>
Mon, 27 Jul 2015 11:50:21 +0200

Hi Kendy,

On Mon, Jul 27, 2015 at 11:29:29AM +0200, Jan Holesovsky <kendy@collabora.com> wrote:

https://wiki.documentfoundation.org/Development/Unit_Tests

with two things:

* list of areas that have "No fix without a unit test" rule (Miklos, I
  believe you have the same rule in the import/export filters - can you
  please specify there)?


I don't remember I actually reverted any such change, but yes, if my
input is asked during a gerrit review, the first thing I usually check
is if there is a matching unit test (when the area is a Writer filter
change) and if the test fails without the fix.

I've linked the relevant README from the wiki now, I hope that helps.

Regards,

Miklos

Attachment: signature.asc
Description: Digital signature

Context

pushing patches despite requests for a test · Markus Mohrhard
- Re: pushing patches despite requests for a test · Eike Rathke
  - Re: pushing patches despite requests for a test · Bjoern Michaelsen
    - Re: pushing patches despite requests for a test · Jan Holesovsky
      - Re: pushing patches despite requests for a test · Jan Holesovsky
      - Re: pushing patches despite requests for a test · Markus Mohrhard
        
        Re: pushing patches despite requests for a test · Thorsten Behrens
        
        Re: pushing patches despite requests for a test · Jan Holesovsky
        
        Re: pushing patches despite requests for a test · Miklos Vajna
- Re: pushing patches despite requests for a test · Tomaž Vajngerl
  - Re: pushing patches despite requests for a test · Tomaž Vajngerl
- Re: pushing patches despite requests for a test · Michael Meeks
  - Re: pushing patches despite requests for a test · Markus Mohrhard
    - Re: pushing patches despite requests for a test · Michael Meeks
  - Re: pushing patches despite requests for a test · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.