Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi Johann
On 01/08/12 15:26, Johann Messner wrote:
hello Noel,
[Cc to Philipp],

I tried to prepare a more "verbose" edition of the
patch set (and especially of the minor modifications
by myself) ... please see

    https://linux.jku.at/messner/LibreOffice/
    (-> patchInfo-31-Jul-2012__for_libreoffice.3.5.3-verbose.txt )

This file should be acceptable to the 'patch' command on a
box with the very same src tree (libreoffice 3.5.3). However,
since you're a developer you use a more advanced version of the libreoffice
source code. You will have to examine (and eventually adopt in a
cleaned up fashion) some of the code pieces very carefully..
we try to make the process for submitting patches really easy ( for both submitters and developers/reviewers ) we don't require much. But really a patch ( ontop of another patch ) and the whole lot based on top of an old source version doesn't make things easy to review. Ok, granted this is abit of a special case since some of the patches involved are not committed, so... I have committed the remaining xml and preview related fixes to master. Can you please checkout the current master, make your changes and create your patches against that. That avoids messy time consuming and error prone steps of trying to trace through a large patch trying to filter special custom markup to detect the relevant changes. It would really help us if you could do that, if you have problems either creating the patches and/or getting/building the master branch there is plenty of help at hand and we are ready and happy to help you.

regards,
Noel


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.