Re: Proposal/Prototype support for "fill in character" in Calc Number Format Strings // final patch set

Hi Noel,

I managed to use and learn from your patches published in the
thread 28410 on http://thread.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/
Some minor modifications were useful to close some gaps (glitches).

Please get my "final" patch info set for my local libreoffice-3.5.3 
file tree on

   https://linux.jku.at/messner/LibreOffice/
   (-> file:  patchInfo-31-Jul-2012__for_libreoffice.3.5.3.txt  )

Please have a look at the modifications and adopt them if you
feel they are useful.

I will be on holiday for the next 2 weeks ... 

Many thanks again for preparing this fine work. I am confident
that the support for a fill-in character (in order to implement
user defined "accounting number formats") will promote the acceptance
of LibreOffice Calc at the office desktop PC.


Regards,
hans



Am Do, 26.Jul.12, KW30 (13:06:22 Uhr) schrieb Noel Power <nopower@suse.com>:
> Hi Johann,
>
> On 24/07/12 10:32, Noel Power wrote:
> > Hi Johann,
> >
> > firstly apologies for the late replying, I have only just got back 
> > from vacation and am catching up with email.
> > On 06/07/12 18:10, Kohei Yoshida wrote:
> > > Hi Johann,
> > >
> > > I hope you don't mind me forwarding this nice work of yours to our 
> > > main development mailing list, to let other interested developers 
> > > know of your work.  Let me also CC Noel since he's done a very 
> > > similar work for 3.6.  There may be some overlap between his work and 
> > > yours...
> //
> Hopefuily I didn't blind you with too many details with the last email. 
> Put more simply what I would really love is if you could look to see if 
> we need to amend  the width calculation that is located here
> http://opengrok.libreoffice.org/xref/core/sc/source/ui/view/output2.cxx#554
> and see if we need to include the work you already did. it would be 
> brilliant to get your input on that and even some patch/code from you to 
> improve it.
> Also if you wish you could help with is the patch for enabling 
> persisting to odf needs updating to use "<number:fill-character>" 
> instead of "number:repeated", of course any other general testing. bug 
> reporting & patches in this area wildly appreciated also. Are you 
> interested or have any time for any of that?
>
> Noel