Re: [PATCH] gtk: listbox border was not rendered

Hi Ivan,

On Sat, Jul 28, 2012 at 5:39 AM, Ivan Timofeev <timofeev.i.s@gmail.com>wrote:
> there was a discussion about ugly listboxes in gtk theming, and we
> decided to draw a border

I was the one who made the original patch that set listboxes to integer
heights of the list items, which was reverted for causing trouble. The
reason I wanted to fully show all list items was not because partially
shown list items looked bad. It was because of the work I was doing in the
list of custom animations: when a custom animation list item was moved to
the bottom of the visible list items, I wanted to scroll the visible area
so that the selected list item would remain fully visible. Right now, if
the last item is half shown, moving a selected custom animation list item
to that position means it goes partly out of view, which is bad.

I couldn't get the list view to scroll down in this case, since it thought
that all items were in view already. They were, but the selected one was
not *fully* in view (see attached image). My patch (which has been
reverted) attempted to get around the issue by making it never happen.

I'm sorry, but I think that the added border looks bad where it goes beside
the scroll bars - see other attached image.

Kind regards,

Luke.

Attachment: List Item Problem.png
Description: PNG image

Attachment: Border Problem.png
Description: PNG image