Re: [PATCH] gtk: listbox border was not rendered

Hello,

This mostly looks good, but breaks a bit border for oxygen-gtk (which
somehow has worked before the patch, unlike other themes). Namely, the
border now appears to be 1px while it should be 2px. I'd suggest using
getFrameWidth() to adjust the shadow rect.
OTOH, we've done quite some customizations in oxygen-gtk before to
make it look better with LibO, so maybe this is what should be changed
on oxygen-gtk side.

Regards,
Ruslan

On Fri, Jul 27, 2012 at 9:39 PM, Ivan Timofeev <timofeev.i.s@gmail.com> wrote:
> Hi!
>
> there was a discussion about ugly listboxes in gtk theming, and we
> decided to draw a border:
>
> http://nabble.documentfoundation.org/PATCH-Revert-Set-the-listbox-height-to-an-integer-multiple-of-the-listbox-entry-height-tp3969374p3980299.html
>
> and after a more than 2 month *cough* I have figured out what is wrong.
> The problem is in gtk plugin which does some weird things when drawing
> a listbox (see the description in the patch).
> I have no idea why it does that, git blame shows that it is from the
> initial import. It would be great if someone review the patch, I am
> absolutely not sure.
>
> The famous before.png and after.png are attached.
>
> Thanks!
>
> Ivan
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice