Re: [PATCH] gtk: listbox border was not rendered

Hi Luke,

On 01.08.2012 03:29, Luke Symes wrote:
> I was the one who made the original patch that set listboxes to integer
> heights of the list items, which was reverted for causing trouble. The
> reason I wanted to fully show all list items was not because partially
> shown list items looked bad. It was because of the work I was doing in
> the list of custom animations: when a custom animation list item was
> moved to the bottom of the visible list items, I wanted to scroll the
> visible area so that the selected list item would remain fully visible.

Sorry, my brain quickly messes things up...

> Right now, if the last item is half shown, moving a selected custom
> animation list item to that position means it goes partly out of view,
> which is bad.

This commit fixes that for me:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6657052e463b4ff9c8a005faadcf2289d32343a3
Does it look ok to you?

> I'm sorry, but I think that the added border looks bad where it goes
> beside the scroll bars - see other attached image.

That is how it already looks in Tools - Customize - Events, and how it 
always looked on Windows I guess. Of course in native gtk apps 
scrollbars seem to be always placed outside of a listbox...

Best regards,
Ivan