Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Thu, Jun 14, 2012 at 1:59 AM, Stephan Bergmann <sbergman@redhat.com> wrote:
On 06/13/2012 03:00 PM, Norbert Thiebaud wrote:


I think you are confusing buildability after each patch of a series has been
applied in sequence (which is a desirable property indeed) vs. buildable
with each patch of a series applied individually ("out of context," what
Eike's concern was).

When you apply a series in sequence, at any point the result must be
buildable...
1/ it is good practice
2/ if that is not the case bisection is much harder

If you pushed directly to master and happened to push something that
is not buildable, then of course you can't go back and fix it...
but with gerrit, as long as your patches series is not 'merged' then
you can git rebase interactive to fix the offending commit.

Yes, you cannot pick a random patch in a series, apply just that and
expect it to be buildable
but if my series has 3 patches 1,2,3

the If I apply (1) (1,2) or (1,2,3) I expect the result to be buildable

Norbert

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.