Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer)

Miklos Vajna <vmiklos -AT- suse.cz>
Thu, 31 May 2012 17:29:15 +0200

Hi Eike,

On Thu, May 31, 2012 at 05:18:53PM +0200, Eike Rathke <erack@redhat.com> wrote:

Thanks! Pushed all three. I onlychanged the commit comments to be in
present tense, as I think is better. (Instead of "cleaned up
comments", "Clean up comments".)


I think that past tense actually makes more sense, given that comments
are read later, especially in a changelog or other listings, i.e. list
of bugs fixed.


Related:
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

I think consistency with git merge/revert is good. (But of course it's
not a huge issue. :-) )

Miklos

Context

Re: [PATCH] fdo#39468: translate German comments (=> writer) (continued)
- Re: [PATCH] fdo#39468: translate German comments (=> writer) · Philipp Riemer
  - Re: [PATCH] fdo#39468: translate German comments (=> writer) · Philipp Riemer
  - Re: [PATCH] fdo#39468: translate German comments (=> writer) · Philipp Riemer
  - Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer) · Tor Lillqvist
    - Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer) · Philipp Riemer
      - Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer) · Tor Lillqvist
        
        Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer) · Philipp Riemer
        
        Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer) · Philipp Riemer
        
        Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer) · Tor Lillqvist
        
        Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer) · Eike Rathke
        Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer) · Miklos Vajna
        
        Re: [PATCH] [PUSHED] fdo#39468: translate German comments (=> writer) · Michael Meeks
  - Re: [PATCH] fdo#39468: translate German comments (=> writer) · Christina Roßmanith

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.