Thank you very much! Pushed. Welcome as a LibreOffice contributor!
A couple of minor requests for you future patches: Please do combine
changes to several files into one patch, easier to handle them that
way... For translation patches, something like half a dozen files per
patch perhaps is ideal?
It is unnecessary to translate comments that we consider pointless,
like the kind that say why (at some point in time) a header was
included.
#include <swundo.hxx> // fuer die UndoIds
Just remove such comments.
You can also just remove information-free boilerplate function header
comments like:
/*************************************************************************
|*
|* void SwHistory::Add()
|*
|*
*************************************************************************/
these just waste vertical space, which is the most valuable resource
in a source file;)
And finally, in comments like:
+ //JP 20.04.98: Bug 49502 - When a formula is set,
never save
+ // the value. It possibly must be recalculated!
+ //JP 30.07.98: Bug 54295 - Save formulas always in plain
+ // text
the initials and dates are of questionable value; we have version
control for changes since 2000. Also, for comments this old, the bug
number is meaningless. So the comment above could be edited into
something like:
+ // When a formula is set, never save the value.
It possibly must be recalculated.
+ // Save formulas always in plain text.
(Yeah, the over-enthusiastic use of exclamation marks can also be reduced...)
--tml
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.