Hey, I had some sparetime again... Find attached the next patches for a few files in "sw/source/core/undo/" where I tried to consider hopefully all of Tor's recommendations. As a result, the deletion count is much higher than the number of inserts. Cheers, Philipp -- Diffstat: sw/source/core/undo/rolbck.cxx | 108 ++----------- sw/source/core/undo/unattr.cxx | 27 +--- sw/source/core/undo/undel.cxx | 16 +-- sw/source/core/undo/undobj.cxx | 40 ++--- sw/source/core/undo/undobj1.cxx | 18 +-- sw/source/core/undo/unfmco.cxx | 15 +-- sw/source/core/undo/unmove.cxx | 15 +-- sw/source/core/undo/unnum.cxx | 29 +--- sw/source/core/undo/unovwr.cxx | 16 +-- sw/source/core/undo/unredln.cxx | 7 +- sw/source/core/undo/unsort.cxx | 40 ++--- sw/source/core/undo/unspnd.cxx | 19 +-- sw/source/core/undo/untbl.cxx | 348 +++++++++++++++------------------------ 13 files changed, 206 insertions(+), 492 deletions(-) 2012/5/28 Tor Lillqvist <tml@iki.fi>:
Thank you very much! Pushed. Welcome as a LibreOffice contributor! A couple of minor requests for you future patches: Please do combine changes to several files into one patch, easier to handle them that way... For translation patches, something like half a dozen files per patch perhaps is ideal? It is unnecessary to translate comments that we consider pointless, like the kind that say why (at some point in time) a header was included. #include <swundo.hxx> // fuer die UndoIds Just remove such comments. You can also just remove information-free boilerplate function header comments like: /************************************************************************* |* |* void SwHistory::Add() |* |* *************************************************************************/ these just waste vertical space, which is the most valuable resource in a source file;) And finally, in comments like: + //JP 20.04.98: Bug 49502 - When a formula is set, never save + // the value. It possibly must be recalculated! + //JP 30.07.98: Bug 54295 - Save formulas always in plain + // text the initials and dates are of questionable value; we have version control for changes since 2000. Also, for comments this old, the bug number is meaningless. So the comment above could be edited into something like: + // When a formula is set, never save the value. It possibly must be recalculated. + // Save formulas always in plain text. (Yeah, the over-enthusiastic use of exclamation marks can also be reduced...) --tml
Attachment:
0001-translations.patch
Description: Binary data
Attachment:
0002-cleanups.patch
Description: Binary data