Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

Sorry to waste your time, I'll have another run at this on Wednesday,
when I get back from a business trip.

On Sat, Jan 14, 2012 at 00:32, Kohei Yoshida <kohei.yoshida@suse.com> wrote:
> On Fri, 2012-01-13 at 17:00 -0500, Kohei Yoshida wrote:
> > On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote:
> > > Let me do a thorough review of your patch one more time, and I'll push
> > > to master.
> >
> > Unfortunately one of the filters-test fails on master, after applying
> > the patch.  The crash occurs in ScColumn::CloneCell, at line 824 which
> > is
> >
> >     switch (rSource.GetCellType())
> >
> > Hmm....
>
> Noel, it would be great to have you look into this.  I don't have an
> immediate thought on what could be causing the crash, but we can't apply
> it as-is obviously.
>
> If you have the latest master build, try opening
> sc/qa/unit/data/ods/named-ranges-global.ods
>
> and it crashes over here.  Without the patch, the file opens fine.
>
> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc