Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

On Fri, 2012-01-13 at 09:06 +0200, Noel Grandin wrote:
> Hi
>
> This patch converts open-coded array management to std::vector in ScColumn

Hello Noel,

I just took a quick look at your patch, and it looks good & I'm more
than willing to push this change verbatim.

The only thing I'd like to check is that, I believe we had some sort of
column array resizing policy which controls whether we should increase
its size only to the minimum necessary size or increase it to a size
larger than necessary to avoid future reallocation.  We do change this
policy sometimes during import which reduces import performance quite a
bit.

Once I check that bit, and if nothing else is wrong, I'll commit this to
master.

Thanks a lot for your patch.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc