Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

Kohei Yoshida <kohei.yoshida -AT- suse.com>
Fri, 13 Jan 2012 17:00:59 -0500

On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote:

Let me do a thorough review of your patch one more time, and I'll push
to master.


Unfortunately one of the filters-test fails on master, after applying
the patch.  The crash occurs in ScColumn::CloneCell, at line 824 which
is

    switch (rSource.GetCellType())

Hmm....

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

Context

[Libreoffice] [PATCH] ScColumn - convert array to vector · Noel Grandin
- Re: [Libreoffice] [PATCH] ScColumn - convert array to vector · Noel Grandin
- Re: [Libreoffice] [PATCH] ScColumn - convert array to vector · Kohei Yoshida
  - Re: [Libreoffice] [PATCH] ScColumn - convert array to vector · Kohei Yoshida
    - Re: [Libreoffice] [PATCH] ScColumn - convert array to vector · Noel Grandin
      - Re: [Libreoffice] [PATCH] ScColumn - convert array to vector · Kohei Yoshida
        
        Re: [Libreoffice] [PATCH] ScColumn - convert array to vector · Kohei Yoshida
        
        Re: [Libreoffice] [PATCH] ScColumn - convert array to vector · Kohei Yoshida
        
        Re: [Libreoffice] [PATCH] ScColumn - convert array to vector · Noel Grandin

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.