On Thu, Dec 01, 2011 at 07:11:04PM -0800, Mike Whiteley wrote:
From 3fb61e525f5a15fab65c6ab494d5c4d0135a2471 Mon Sep 17 00:00:00 2001
From: mikew <mikew@E15519.(none)>
Date: Thu, 1 Dec 2011 19:13:20 -0800
Subject: [PATCH] translated some comments from German to English
Thanks. A few remarks, though. Please do (once on each computer you
use to prepare patches using git):
$ git config --global user.name "Firstname Lastname"
$ git config --global user.email "your_email@youremail.com"
So that your patches are properly attributed when imported.
I also have a few remarks on the translations:
--- a/comphelper/inc/comphelper/container.hxx
+++ b/comphelper/inc/comphelper/container.hxx
@@ -49,15 +49,16 @@ protected:
- // das aktuelle Objekt
+ // The actual object
No, DE:"aktuel" is EN:"current". EN:actual is DE:tatsächlich or
DE:wirklich or DE:eigentlich.
::std::vector<sal_Int32> m_arrChildIndizies;
- // ich bewege mich eigentlich durch einen Baum, dummerweise haben dessen
- // Elemente aber kein GetNextSibling, also muss ich mir merken, wo die Childs
- // innerhalb ihres Parents sitzen (das ist sozusagen der Pfad von der Wurzel
- // zu m_xCurrentObject
+
+ // Actually, as I move through this tree, there are elements but NO
+ // GetNextSibling, so I have to remember where each child
+ // is in relation to it's parent. This is the path from the
+ // root node to m_xCurrentObject
I changed that to:
// I'm moving through a tree, but its elements have no GetNextSibling,
// so I have to remember where each child is in relation to its parent.
// That is the path from the root node to m_xCurrentObject
Which "flows" better to my ear, and is a closer translation of the
German anyway.
it's = short for "it is" (DE:es ist)
its = pronoun (DE:sein(e))
Note: Here you could have used EN:actual, a good translation for
"eigentlich": I'm actually moving through a tree. As a *very* minor
stylistic point I have decided to just drop it, but wouldn't have
bothered removing it if the translation of the whole sentence was
idiomatic in the first place.
- // damit kann man bestimmte Elemente ausschliessen, die werden dann einfach
- // uebergangen
- // wenn hier sal_True zurueckkommt, wird dieses Element von Next zurueckgeliefert, man
kann sich hier also auch
- // gleich ein paar zusaetzliche Angaben zu dem Element holen (deswegen ist die Methode
auch nicht const)
+
+ // So we can exclude certain elements, which are expected
+ // if this returns sal_True. If so, this element will be returned,
+ // which also allows us to return additional information.
+ // That's why this method is not const.
So *that* we can exclude (...)
I've now idea where you got the "expected" from, that's not in the
German.
More generally, you have destroyed the meaning of the German (which
was indeed not 100% well). Changed to:
// This can be used to exclude certain elements; elements for which
// this function returns sal_True will be simply skipped.
// If this element is returned from Next(), then one can get
// here get a little more information on the element.
// That's why this method is not const.
Assuming that the German meant:
// Damit kann man bestimmte Elemente ausschliessen, die werden dann einfach
// übergangen wenn hier sal_True zurückkommt.
// Wird dieses Element von Next zurückgeliefert, dan kann man sich hier also auch
// gleich ein paar zusätzliche Angaben zu dem Element holen (deswegen ist die Methode auch
nicht const)
--
Lionel
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.