Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On Sun, 2011-01-16 at 12:07 +0100, Julien Nabet wrote:
Hello,

Here is a patch for some cppcheck cleaning in ucb
Compiling was ok

Pushed the first part.

For the second one, that one in gio is a false positive, it's only
compiled with you do --enable-gio, which is probably why it compiled
clearly for you.

cppcheck I guess doesn't see the line where MountOperation::Completed is
passed as a callback to some other code as a "use" of the method.

I let this one :
[./source/ucp/tdoc/tdoc_content.hxx:69]: (warning) Member variable 
'ContentProperties::m_eType' is not initialised in the constructor.
because i don't know what to put by default (how to know that in this 
case ?).

I'd typically have a look at the enum, and see if there's a "UNKNOWN" or
"DEFAULT" value for the enum, and if not, then grab the first enum name,
e.g. in this case the first one is "STREAM", so I'd just use that.

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.