[Libreoffice] [FIXED] Re: [PATCH] possible null-dereferencing found by cppcheck

Caolán McNamara <caolanm -AT- redhat.com>
Mon, 17 Jan 2011 12:09:16 +0000

On Sun, 2011-01-16 at 18:55 +0900, Takeshi Abe wrote:

Hi,

cppcheck said that

[impress/sd/source/ui/func/fusnapln.cxx:186]: (error) Possible null pointer dereference: pPV

which is, at a glance, worth noting.
It would be great if someone shows the de-referenceing has no problem,
otherwise the attached patch may provides a workaround.


The complaint is because of the route through the logic where pPV can
definitely be NULL when it hits those lines, I reckon the easiest thing
is to ensure it's always set at the start, which will silence cppcheck
and appears to be the way it works in practice.

C.

Context

[Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Takeshi Abe
- [Libreoffice] [FIXED] Re: [PATCH] possible null-dereferencing found by cppcheck · Caolán McNamara
- Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Tor Lillqvist
  - Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Takeshi Abe
    - Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Tor Lillqvist
      - Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Takeshi Abe
        
        Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Tor Lillqvist
        
        Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Caolán McNamara
        
        Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck · Takeshi Abe
        
        [Libreoffice] [PUSHED] Re: [PATCH] possible null-dereferencing found by cppcheck · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.